[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46

ricardozanini · 2024-05-22T16:51:11Z

Description of the change:

Comprehends:

SRVLOGIC-266 - Fix operator's metadata information on OpenShift Console
SRVLOGIC-185 - Serverless logic operator builder is not able to find builder config ConfigMap (Somewhat, needs verification now that the CM is configurable)
SRVLOGIC-299 - Downgrade Go to 1.20 in Serverless Logic 1.33 Operator

Motivation for the change:
Since we have now the newly Go 1.21 image officially, we can make it easier by just upgrading our base image:
https://catalog.redhat.com/software/containers/ubi8/go-toolset/5ce8713aac3db925c03774d1?architecture=amd64&image=66452129e206ab012dc21031

Additionally, I've upgraded the JDK images and set to ubi8 for ubiquiteness.

@rgdoliveira @domhanak can you please inform/confirm the image tags for these, so I can update the PR?

# The Jobs Service image to use, if empty the operator will use the default Apache Community one based on the current operator's version
jobsServicePostgreSQLImageTag: ""
jobsServiceEphemeralImageTag: ""
# The Data Index image to use, if empty the operator will use the default Apache Community one based on the current operator's version
dataIndexPostgreSQLImageTag: ""
dataIndexEphemeralTag: ""
# SonataFlow base builder image used in the internal Dockerfile to build workflow applications in preview profile
# Order of precedence is:
# 1. SonataFlowPlatform in the given namespace
# 2. This configuration
# 3. The FROM in the Dockerfile in the operator's namespace "sonataflow-operator-builder-config" configMap.
# If 1 or 2, the FROM tag will be replaced by the tag se there.
# If empty the operator will use the default Apache Community one based on the current operator's version.
sonataFlowBaseBuilderImageTag: "registry.redhat.io/openshift-serverless-1/logic-swf-builder-rhel8:1.33"
# The image to use to deploy SonataFlow workflow images in devmode profile.
# If empty the operator will use the default Apache Community one based on the current operator's version.
sonataFlowDevModeImageTag: "registry.redhat.io/openshift-serverless-1/logic-swf-devmode-rhel8:1.33"

Checklist

Add or Modify a unit test for your change
Have you verified that tall the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…ge 1.21; Bundles Update; Manager Config set Signed-off-by: Ricardo Zanini <[email protected]>

Signed-off-by: Ricardo Zanini <[email protected]>

wmedvede

I have added some minor comment regarding the usage of ubi8 vs ubi9 in case it could make sense.

wmedvede · 2024-05-22T17:05:37Z

bundle.prod/manifests/logic-operator-rhel8-builder-config_v1_configmap.yaml

+    arguments to pass to the builder\nARG MAVEN_ARGS_APPEND\n\n# Copy from build context
+    to skeleton resources project\nCOPY --chown=1001 . ./resources\n\nRUN /home/kogito/launch/build-app.sh
+    ./resources\n  \n#=============================\n# Runtime Run\n#=============================\nFROM
+    registry.access.redhat.com/ubi8/openjdk-17-runtime:latest\n\nENV LANG='en_US.UTF-8'


@ricardozanini Just a reminder to double-check. In 9.99.x-pod (i.e., previous release), it looks like we used
registry.access.redhat.com/ubi9/openjdk-17:latest instead.

see:

kogito-serverless-operator/bundle.osl/manifests/logic-operator-rhel8-builder-config_v1_configmap.yaml

Line 11 in 5325a42

Runtime Run\n#=============================\nFROM registry.access.redhat.com/ubi9/openjdk-17:latest\n\nENV

talking to my self.... after seen the image names provided by @rgdoliveira .

If produtized DI and JS images are on rhel8....
registry.redhat.io/openshift-serverless-1/logic-jobs-service-postgresql-rhel8:1.33.0

maybe ubi8 is the correct choice here.
Anyway, just forget my comment if don't make sense.

It was ubi9, but yeah I'm downgrading to align and avoid problems.

wmedvede · 2024-05-23T07:13:55Z

config/manager/SonataFlow-Builder.containerfile

@@ -16,7 +16,7 @@ RUN /home/kogito/launch/build-app.sh ./resources
 #=============================
 # Runtime Run
 #=============================
-FROM registry.access.redhat.com/ubi9/openjdk-17:latest
+FROM registry.access.redhat.com/ubi9/openjdk-17-runtime:latest


regarding my previous comment, here we have ubi9

That's fine this one is upstream.

wmedvede · 2024-05-23T07:14:44Z

config/manager/prod/SonataFlow-Builder.containerfile

@@ -16,7 +16,7 @@ RUN /home/kogito/launch/build-app.sh ./resources
 #=============================
 # Runtime Run
 #=============================
-FROM registry.access.redhat.com/ubi9/openjdk-17:latest
+FROM registry.access.redhat.com/ubi8/openjdk-17-runtime:latest


ubi8 here, IDK, just a reminder

This one is midstream.

wmedvede · 2024-05-23T07:16:44Z

images/prod-operator-image.yaml

@@ -15,7 +15,7 @@
 - schema_version: 1
  name: "operator-builder"
  version: "1.33.0"
-  from: "registry.access.redhat.com/ubi8/go-toolset:1.20.12"
+  from: "registry.access.redhat.com/ubi8/go-toolset:1.21"


same here, ubi8.

That's midstream.

rgdoliveira

@ricardozanini I've suggested the correct prod images tags.

bundle.prod/manifests/logic-operator-rhel8-controllers-config_v1_configmap.yaml

config/manager/prod/controllers_cfg.yaml

rgdoliveira · 2024-05-23T07:24:52Z

Also something that is missing for the bundle is the annotations for infra feature tests, same thing you did for OSL 1.32 in Jira SRVLOGIC-245, can you please also add that in this PR?

Signed-off-by: Ricardo Zanini <[email protected]>

ricardozanini added 2 commits May 22, 2024 13:43

[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Ima…

c1ff243

…ge 1.21; Bundles Update; Manager Config set Signed-off-by: Ricardo Zanini <[email protected]>

Adding remanining files

e188d35

Signed-off-by: Ricardo Zanini <[email protected]>

ricardozanini requested review from wmedvede, domhanak, jakubschwan and rgdoliveira May 22, 2024 16:51

wmedvede approved these changes May 23, 2024

View reviewed changes

rgdoliveira reviewed May 23, 2024

View reviewed changes

Update version to 1.33.0 and 9.100.0.redhat-00004

18b87ef

Signed-off-by: Ricardo Zanini <[email protected]>

rgdoliveira approved these changes May 23, 2024

View reviewed changes

rgdoliveira merged commit 5225762 into kiegroup:9.100.x-prod May 23, 2024
2 of 4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46

[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46

ricardozanini commented May 22, 2024

wmedvede left a comment

wmedvede May 22, 2024

wmedvede May 23, 2024

ricardozanini May 23, 2024

wmedvede May 23, 2024

ricardozanini May 23, 2024 •

edited

Loading

wmedvede May 23, 2024

ricardozanini May 23, 2024

wmedvede May 23, 2024

ricardozanini May 23, 2024

rgdoliveira left a comment •

edited

Loading

rgdoliveira commented May 23, 2024

[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46

[9.100.x-prod] SRVLOGIC-299 SRVLOGIC-266 SRVLOGIC-185 - Update Go Image 1.21; Bundles Update; Manager Config set #46

Conversation

ricardozanini commented May 22, 2024

wmedvede left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ricardozanini May 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rgdoliveira left a comment • edited Loading

Choose a reason for hiding this comment

rgdoliveira commented May 23, 2024

ricardozanini May 23, 2024 •

edited

Loading

rgdoliveira left a comment •

edited

Loading